fix(tooltip): fix the page will be frozen if multiple tooltips are provided. #16347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent the tooltip component from falling into a infinite loop that freezes the page.
|
Thanks for your contribution! The pull request is marked to be |
This was
linked to
issues
Jan 8, 2022
Closed
Closed
|
One question: Whether this warning should output only once? |
pissang
reviewed
Jan 8, 2022
I think it's reasonable and not too much to give a warn each time |
plainheart
commented
Jan 8, 2022
… how many tooltips are provided.
pissang
approved these changes
Jan 8, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
Before: What was the problem?
As the Multiple Tooltip doesn't get supported yet, the page will get frozen if more than one tooltip is provided.
After: How is it fixed in this PR?
Check if there already exists a tooltip component and avoid creating another one to prevent the tooltip component from falling into an infinite loop that freezes the page.
Misc
Related test cases or examples to use the new APIs
Please refer to
test/tooltip-multiple.htmlOthers
Merging options
Other information