Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): support legend.symbolRotate and inherit from series by default #14876

Merged
merged 7 commits into from
May 17, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented May 6, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Supporting legend.symbolRotate and inherit from series by default.

Fixed issues

Details

Before: What was the problem?

Symbol rotation is always 0 and cannot be configured.

After: How is it fixed in this PR?

Symbol rotation is inherited from series value by default and can be configured with legend.symbolRotate and legend.data.symbolRotate.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

Completed visual test with 5.1.1 as baseline and found no problem.

@echarts-bot
Copy link

echarts-bot bot commented May 6, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels May 6, 2021
@Ovilia Ovilia linked an issue May 10, 2021 that may be closed by this pull request
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 14, 2021
@Ovilia Ovilia merged commit 76ae21d into master May 17, 2021
@echarts-bot
Copy link

echarts-bot bot commented May 17, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-legend-rotate branch May 17, 2021 05:48
Ovilia added a commit to apache/echarts-doc that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support legend.symbolRotate and inherit from series by default
2 participants