New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] fix #9847 #9849

Merged

chickenlj merged 1 commit into apache:3.0 from wangchengming666:fix-#9847

Mar 30, 2022

Member

wangchengming666 commented Mar 29, 2022 •

edited

Loading

翻了以前的一些issue 比如 #8212 和 #5122 都提到过这个问题，我认为这段强校验的代码没必要存在。

    if (actualTypeArgsLength != 2) {
        throw new IllegalArgumentException(MessageFormat.format(
                "[ServiceDefinitionBuilder] Map type [{0}] with unexpected amount of arguments [{1}]."
                        + Arrays.toString(actualTypeArgs), type, actualTypeArgs));
    }

虽然可以通过SPI来扩展，但是还是给用户带来了一定的困扰。


          fix #9847

6e10df9

chickenlj added this to the 3.0.8 milestone

chickenlj merged commit 807b10e into apache:3.0

wangchengming666 deleted the fix-#9847 branch

March 30, 2022 07:48

tiger822 commented Mar 30, 2022

第一次遇见阿里产品里面响应这么快的，给你666个赞，thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet