Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.8 #979

Merged
merged 10 commits into from
Nov 30, 2017
Merged

2.5.8 #979

merged 10 commits into from
Nov 30, 2017

Conversation

mercyblitz
Copy link
Contributor

What is the purpose of the change

Add Annotation @EnableDubboConfigBinding for properties to bind Dubbo Config

Add Annotation @EnableDubboConfigBindings for multiple annotated purposes

see issue

Add @DubboComponentScan compatibility for Spring 3.2.x

see issue

Add part-support of Property placeholders for @DubboComponentScan

For example :

@com.alibaba.dubbo.config.annotation.Service(
        version = "2.5.7",
        application = "${demo.service.application}",
        protocol = "${demo.service.protocol}",
        registry = "${demo.service.registry}"
)

Verifying this change

Run DubboConfigBindingRegistrarTest for test cases

Run DubboConfigBindingsRegistrarTest for test cases

@mercyblitz mercyblitz merged commit 6b2fa86 into apache:master Nov 30, 2017
@mercyblitz mercyblitz requested a review from chickenlj November 30, 2017 07:05
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
* Update version to 2.5.8

* Update version to 2.5.8

* Add compatibility for Spring 3.2.x to resolve apache#17

* Add compatibility for Spring 3.2.x to resolve apache#17

* Add compatibility for Spring 3.2.x to resolve apache#17

* Add final to BEAN_NAME field

* Fixed apache#883

* Add @EnableDubboConfigBinding to fix apache#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant