增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 #784

zhangyinyue · 2017-10-26T10:12:48Z

#726 提交太多文件有点乱，关闭 #726，重新提交代码

Authorlove · 2017-10-26T14:20:19Z

 public void validate(String methodName, Class<?>[] parameterTypes, Object[] arguments) throws Exception {
        String methodClassName = clazz.getName() + "$" + toUpperMethoName(methodName);
        Class<?> methodClass = null;
        try {
            methodClass = Class.forName(methodClassName, false, Thread.currentThread().getContextClassLoader());
        } catch (ClassNotFoundException e) {
        }

这里修改之后，下面执行save方法时，会默认校验Save.class分组

 @interface Save {
    } // 与方法同名接口，首字母大写，用于区分验证场景，如：@NotNull(groups = ValidationService.Save.class)，可选

参考 #504
方法上多个group上的校验，可以在parameter上配置该group实现，我觉得新增一个注解的意义不大。
@zhangyinyue

Authorlove · 2017-10-26T14:24:33Z

...ig/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/validation/ValidationService.java

+     */
+    @MethodValidated({Save.class, Update.class})
+    void relatedQuery(ValidationParameter parameter);
+
    @interface Save {
    } // 与方法同名接口，首字母大写，用于区分验证场景，如：@NotNull(groups = ValidationService.Save.class)，可选

    @interface Update {
    } // 与方法同名接口，首字母大写，用于区分验证场景，如：@NotNull(groups = ValidationService.Update.class)，可选



这里可以添加

@interface RelatedQuery {}

Authorlove · 2017-10-26T14:26:16Z

.../dubbo-config-api/src/test/java/com/alibaba/dubbo/config/validation/ValidationParameter.java

@@ -34,6 +34,9 @@

    private static final long serialVersionUID = 7158911668568000392L;

+    @NotNull(groups = ValidationService.Update.class)
+    private Integer id;


@NotNull(groups = {ValidationService.Update.class,ValidationService.RelatedQuery.class}) private Integer id;

zhangyinyue · 2017-10-27T03:12:09Z

我觉得应该是这样的，你现在说的这个方案是读取以方法名为默认的分组来检查，如果我对relatedQuery方法，想用Save的分组来检查，现在的逻辑没法实现。现在每多一个方法，就要多一个分组。如果类的方法多了，那属性上注解的分组也就跟着多了，很不方便。而且分组我可以提炼出一个公共的名字，多个方法共用。并不一定按我这个实现，但希望考虑的我建议。@Authorlove

Authorlove · 2017-10-27T05:26:20Z

...er-validation/src/main/java/com/alibaba/dubbo/validation/support/jvalidation/JValidator.java

            throw new ConstraintViolationException("Failed to validate service: " + clazz.getName() + ", method: " + methodName + ", cause: " + violations, violations);
        }
    }

-    private void validate(Set<ConstraintViolation<?>> violations, Object arg, Class<?> clazz, Class<?> methodClass) {
+    private void validate(Set<ConstraintViolation<?>> violations, Object arg, Class<?> clazz, Class<?> methodClass, Class<?>[] methodClasses ) {


这里可以改成

private void validate(Set<ConstraintViolation<?>> violations, Object arg, Class<?>... groups)

Authorlove · 2017-10-27T05:28:12Z

...er-validation/src/main/java/com/alibaba/dubbo/validation/support/jvalidation/JValidator.java

+            } else if (methodClasses != null) {
+                for (int i = 0; i < methodClasses.length; i++) {
+                    violations.addAll(validator.validate(parameterBean, Default.class, clazz, methodClasses[i]));
+                }


for循环去掉吧，维护个List<Class<?>> groups，最后groups.toArray(new Class[0])

Authorlove · 2017-10-27T05:28:37Z

...lter/dubbo-filter-validation/src/main/java/com/alibaba/dubbo/validation/MethodValidated.java

+ * @author: zhangyinyue
+ * @Createdate: 2017年10月10日 16:34
+ */
+@Target({ElementType.METHOD})


可以考虑支持参数注解

在方法层面上注解，本来就是作用在参数上的；这个注解应该是要跟方法相关的吧，本来意义就是不同方法需要检查的参数分组不一样，应该没必要加上参数上面吧。

Authorlove · 2017-10-27T05:30:16Z

@zhangyinyue 这个注解灵活一些，可以加进来，你看看我comment的地方，完善下

Authorlove · 2017-10-30T03:34:57Z

...er-validation/src/main/java/com/alibaba/dubbo/validation/support/jvalidation/JValidator.java

@@ -231,51 +235,60 @@ else if (memberValue instanceof ArrayMemberValue) {
    }

    public void validate(String methodName, Class<?>[] parameterTypes, Object[] arguments) throws Exception {
+        List<Class<?>> groups = new ArrayList<>();


Please set your api level to jdk1.6

Authorlove · 2017-10-30T03:37:27Z

...lter/dubbo-filter-validation/src/main/java/com/alibaba/dubbo/validation/MethodValidated.java

+ * 表示relatedQuery这个方法需要同时检查Save和Update这两个分组
+ * @author: zhangyinyue
+ * @Createdate: 2017年10月10日 16:34
+ */


bad java doc, please follow java doc's specification

* 增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 * 将需要检查的分组维护到List<Class<?>> groups中，包括当前接口类及Default.class两个默认的分组 * 修改接口级别为jdk1.6; 按javadoc规范修改注释

增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释

ffcee9b

zhangyinyue mentioned this pull request Oct 26, 2017

增加MethodValidated注解，修改JValidator.java，在接口方法上支持多个自定义分组参数验证； #726

Closed

Authorlove reviewed Oct 26, 2017

View reviewed changes

Authorlove mentioned this pull request Oct 27, 2017

Bean Validation: default method grouping constraint doesn't work #787

Closed

Authorlove reviewed Oct 27, 2017

View reviewed changes

zhangyinyue and others added 2 commits October 27, 2017 14:40

将需要检查的分组维护到List<Class<?>> groups中，包括当前接口类及Default.class两个默认的分组

7b75523

Merge branch 'master' into fix-JValidatorBug

41ab22c

Authorlove reviewed Oct 30, 2017

View reviewed changes

修改接口级别为jdk1.6; 按javadoc规范修改注释

df159c3

Authorlove merged commit 1420cb4 into apache:master Oct 30, 2017

sunmmi mentioned this pull request Jan 14, 2023

Dubbo 3.1.0 用k8s做注册中心，一直watch超时 #11301

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 #784

增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 #784

zhangyinyue commented Oct 26, 2017

Authorlove commented Oct 26, 2017 •

edited

Loading

Authorlove Oct 26, 2017

Authorlove Oct 26, 2017

zhangyinyue commented Oct 27, 2017 •

edited

Loading

Authorlove Oct 27, 2017

Authorlove Oct 27, 2017

Authorlove Oct 27, 2017

zhangyinyue Oct 27, 2017

Authorlove commented Oct 27, 2017

Authorlove Oct 30, 2017

Authorlove Oct 30, 2017

增加MethodValidated注解的测试用例 及对MethodValidated使用场景和用法的说明注释 #784

增加MethodValidated注解的测试用例 及对MethodValidated使用场景和用法的说明注释 #784

Conversation

zhangyinyue commented Oct 26, 2017

Authorlove commented Oct 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhangyinyue commented Oct 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Authorlove commented Oct 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 #784

增加MethodValidated注解的测试用例及对MethodValidated使用场景和用法的说明注释 #784

Authorlove commented Oct 26, 2017 •

edited

Loading

zhangyinyue commented Oct 27, 2017 •

edited

Loading