Remove RPC context in RpcContextTest.testObject #6997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The test
org.apache.dubbo.rpc.RpcContextTest.testObject
is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test. (See PR #6314 for an example of how this could cause issues)Brief changelog
In
RpcContextTest.testObject()
, callRpcContext.removeContext()
to clear remove the RPC context when the test finishes.Verifying this change
With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM).
This fixes #6996 .