-
Notifications
You must be signed in to change notification settings - Fork 26.5k
Add Github Action for Unit test #6726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6726 +/- ##
============================================
+ Coverage 58.84% 59.07% +0.22%
+ Complexity 508 507 -1
============================================
Files 1025 1025
Lines 41341 41341
Branches 6014 6014
============================================
+ Hits 24326 24421 +95
+ Misses 14262 14187 -75
+ Partials 2753 2733 -20 Continue to review full report at Codecov.
|
Changes looks good to me. but there are few things need to be discuss before merge it:
|
hi, @htynkn
yeap, I agree with you. I will disable macOS test case later on.
According to Github Community, we can use at least up to 20 workflows concurrently for dubbo repo itself. For now it is enough for our building rate on travis. |
Codecov Report
@@ Coverage Diff @@
## master #6726 +/- ##
============================================
+ Coverage 59.09% 59.32% +0.23%
+ Complexity 509 508 -1
============================================
Files 1028 1028
Lines 41519 41519
Branches 6037 6021 -16
============================================
+ Hits 24536 24633 +97
+ Misses 14211 14136 -75
+ Partials 2772 2750 -22 Continue to review full report at Codecov.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your investigate and contribution.
Will merge this change to master soon.
At this stage, I can see some duplicate code in github action yml file, maybe we can use some feature like matrix
to make it more clean. those stuff can be done in the future.
What is the purpose of the change
Add Github Action Support for Dubbo Unit Test