Skip to content

Conversation

lfzCarlosC
Copy link

@lfzCarlosC lfzCarlosC commented Aug 19, 2020

What is the purpose of the change

fix #6514

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@lfzCarlosC lfzCarlosC changed the title fix code that violates convention Fix code that violates convention Aug 19, 2020
@AlbumenJ
Copy link
Member

LGTM

@chickenlj chickenlj merged commit 859c9ba into apache:master Aug 26, 2020
@chickenlj chickenlj added this to the 2.7.9 milestone Aug 26, 2020
chickenlj pushed a commit to chickenlj/incubator-dubbo that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some code not follow the convention
3 participants