Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init method models #6352

Closed
wants to merge 1 commit into from
Closed

Conversation

bbq217
Copy link

@bbq217 bbq217 commented Jun 20, 2020

What is the purpose of the change

fix #6228

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #6352 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6352      +/-   ##
============================================
- Coverage     60.86%   60.79%   -0.08%     
+ Complexity      494      493       -1     
============================================
  Files           999      999              
  Lines         39937    39937              
  Branches       5751     5751              
============================================
- Hits          24306    24278      -28     
- Misses        12930    12956      +26     
- Partials       2701     2703       +2     
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/dubbo/rpc/model/ConsumerModel.java 52.08% <100.00%> (ø) 0.00 <0.00> (ø)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/rpc/model/ServiceMetadata.java 48.27% <0.00%> (-3.45%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-3.41%) 19.00% <0.00%> (-1.00%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-2.98%) 0.00% <0.00%> (ø%)
.../dubbo/registry/integration/RegistryDirectory.java 75.43% <0.00%> (-0.87%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) 31.00% <0.00%> (ø%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 52.34% <0.00%> (-0.57%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e51703...602638f. Read the comment docs.

@htynkn htynkn added the type/bug Bugs to being fixed label Jun 22, 2020
@chickenlj
Copy link
Contributor

please see #6376

@chickenlj chickenlj closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo 2.7.6&2.7.7必现服务调不通bug,内含复现demo
4 participants