Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-#6306] add priority order in TypeBuilder #6307

Closed
wants to merge 1 commit into from

Conversation

zjseu
Copy link
Contributor

@zjseu zjseu commented Jun 11, 2020

What is the purpose of the change

Add priority order in TypeBuilder in order to give high priority to user defined TypeBuilder in TypeDefinitionBuilder.
related issue: #6306

Brief changelog

Add default method order in TypeBuilder

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@zjseu zjseu closed this Jun 11, 2020
@zjseu zjseu reopened this Jun 11, 2020
@zjseu zjseu closed this Jun 11, 2020
@zjseu zjseu reopened this Jun 11, 2020
@zjseu zjseu closed this Jun 11, 2020
@zjseu zjseu reopened this Jun 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #6307 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6307      +/-   ##
============================================
- Coverage     60.87%   60.82%   -0.05%     
  Complexity      493      493              
============================================
  Files           999     1000       +1     
  Lines         39930    39932       +2     
  Branches       5752     5752              
============================================
- Hits          24306    24288      -18     
- Misses        12927    12948      +21     
+ Partials       2697     2696       -1     
Impacted Files Coverage Δ Complexity Δ
...bbo/metadata/definition/TypeDefinitionBuilder.java 93.33% <100.00%> (+0.22%) 0.00 <0.00> (ø)
...dubbo/metadata/definition/builder/TypeBuilder.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) 20.00% <0.00%> (-1.00%)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-0.95%) 0.00% <0.00%> (ø%)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 52.34% <0.00%> (-0.57%) 0.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0743042...0c4682f. Read the comment docs.

@mercyblitz mercyblitz requested a review from cvictory June 15, 2020 02:30
@mercyblitz mercyblitz added this to the 2.7.8 milestone Jun 15, 2020
@zjseu zjseu closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants