Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick the first valid interface address before choosing 127.0.0.1 #6211

Merged
merged 8 commits into from
May 25, 2020

Conversation

chickenlj
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #6211 into master will decrease coverage by 0.11%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6211      +/-   ##
============================================
- Coverage     60.89%   60.78%   -0.12%     
+ Complexity      493      492       -1     
============================================
  Files           999      999              
  Lines         39898    39911      +13     
  Branches       5744     5749       +5     
============================================
- Hits          24295    24259      -36     
- Misses        12910    12951      +41     
- Partials       2693     2701       +8     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/utils/NetUtils.java 66.55% <46.15%> (-1.31%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 52.17% <0.00%> (-10.87%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.35% <0.00%> (-4.28%) 0.00% <0.00%> (ø%)
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0.00%> (-2.28%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 78.06% <0.00%> (-1.49%) 0.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df50c1...497fc6a. Read the comment docs.

@qinliujie
Copy link
Contributor

LTGM

@qinliujie qinliujie merged commit 79c8b00 into apache:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants