Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config center support registry multi-address format #6209

Merged
merged 3 commits into from
May 29, 2020

Conversation

chickenlj
Copy link
Contributor

@chickenlj chickenlj commented May 25, 2020

address="zookeeper://127.0.0.1:2181|zookeeper://127.0.0.1:2181"

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #6209 into master will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6209      +/-   ##
============================================
- Coverage     60.88%   60.76%   -0.12%     
+ Complexity      493      490       -3     
============================================
  Files           999      999              
  Lines         39898    39880      -18     
  Branches       5744     5720      -24     
============================================
- Hits          24292    24234      -58     
- Misses        12915    12950      +35     
- Partials       2691     2696       +5     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/RegistryConfig.java 85.49% <33.33%> (-2.11%) 0.00 <0.00> (ø)
...ache/dubbo/config/utils/ConfigValidationUtils.java 75.65% <50.00%> (-0.29%) 0.00 <0.00> (ø)
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 52.53% <60.00%> (-0.40%) 0.00 <0.00> (ø)
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 15.38% <0.00%> (-30.77%) 0.00% <0.00%> (ø%)
...bo/config/event/listener/LoggingEventListener.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...va/org/apache/dubbo/remoting/TimeoutException.java 0.00% <0.00%> (-22.23%) 0.00% <0.00%> (ø%)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 63.82% <0.00%> (-10.64%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) 0.00% <0.00%> (ø%)
...moting/transport/netty4/NettyEventLoopFactory.java 30.00% <0.00%> (-6.37%) 0.00% <0.00%> (ø%)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cb7f5...aed41f3. Read the comment docs.

@chickenlj chickenlj merged commit 5a827df into apache:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants