Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory allocation during address change notification. #5613

Merged
merged 22 commits into from
May 7, 2020
Merged

Reduce memory allocation during address change notification. #5613

merged 22 commits into from
May 7, 2020

Conversation

chickenlj
Copy link
Contributor

  1. Merge registry notification events happened in a certain short interval.
  2. cache URL instances to reduce string -> URL recreation
  3. reduce allocation during export and refer at start up.
  4. add frozen status for URL
  5. use URLBuilder for unfrozen URLs

@chickenlj
performance tuning, reduce memo allocation on address notification path.
f7e0bf5 
1 simplify log, 2 cache URL, 3 disable local file snapshot.
@chickenlj
performance tuning:
074a4e7 
1.reduce mem alloc during export&refer,
2.merge registry address notification event
3.add frozen status for URL
@chickenlj
remove timestamp key from default provider registry keys
77911ea
@chickenlj chickenlj added the status/don’t-merge No plan to merge label Jan 9, 2020
@guohao
Copy link
Contributor

guohao commented Jan 9, 2020

👍

@chickenlj chickenlj added this to the 2.7.6 milestone Feb 11, 2020
@chickenlj chickenlj modified the milestones: 2.7.6, 2.7.7 Feb 20, 2020
@chickenlj
add a quick documentation link
ac720cc
@chickenlj
Merge branch 'master' into registry-perf
19c2bf6 
# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
#	dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
#	dubbo-config/dubbo-config-spring/src/main/resources/META-INF/compat/dubbo.xsd
#	dubbo-config/dubbo-config-spring/src/main/resources/META-INF/dubbo.xsd
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
#	dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java
#	dubbo-registry/dubbo-registry-redis/src/main/java/org/apache/dubbo/registry/redis/RedisRegistry.java
@chickenlj
merge master
616bfeb
@chickenlj
Merge branch 'master' of https://github.com/apache/dubbo
506bb43
@chickenlj
Merge branch 'master' of https://github.com/apache/dubbo
c42ecae
@chickenlj
Merge branch 'master' of https://github.com/apache/dubbo
d122482
@chickenlj chickenlj self-assigned this Apr 3, 2020
@hengyunabc hengyunabc modified the milestones: 2.7.7, 2.7.8 Apr 26, 2020
@chickenlj
Merge branch 'master' of https://github.com/apache/dubbo
b73a967
@chickenlj
Merge branch 'master' into registry-perf
6b16c54 
# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/URL.java
#	dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java
#	dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java
@chickenlj
enable URLStrParser
880d450
@chickenlj
Merge branch 'master' of https://github.com/apache/dubbo
e594cc3
@chickenlj
Merge branch 'master' into registry-perf
17c419b 
# Conflicts:
#	dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/Registry.java
#	dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java
@hengyunabc hengyunabc modified the milestones: 2.7.8, 2.7.7 May 7, 2020
@hengyunabc hengyunabc merged commit 6491ed0 into apache:master May 7, 2020
hengyunabc added a commit that referenced this pull request May 8, 2020
@hengyunabc
Revert "Reduce memory allocation during address change notification. (#…
05ab969 
…5613)"

This reverts commit 6491ed0.
@hengyunabc hengyunabc mentioned this pull request May 8, 2020
Merged
hengyunabc added a commit that referenced this pull request May 8, 2020
@hengyunabc
Revert "Reduce memory allocation during address change notification. (#…
9b212c2 
…5613)" (#6119)

This reverts commit 6491ed0.
@hengyunabc
Copy link
Contributor

这个PR被 revert掉了，原因是：

原来的url：

dubbo://127.0.0.1:9098/org.apache.dubbo.registry.dubbo.RegistryDirectoryTest$DemoService?check=false&interface=org.apache.dubbo.registry.dubbo.RegistryDirectoryTest$DemoService&lazy=true&methods=getXXX&remote.application=

精简后的url:

dubbo://127.0.0.1:9098?check=false&lazy=true&methods=getXXX&refer=interface%3Dorg.apache.dubbo.registry.dubbo.RegistryDirectoryTest%24DemoService&remote.application=
  1. 精简过后的url里没有了 path
  2. 会导致代码里原来用 url.getPath() 来取得 service name的逻辑失效
  3. 如果客户依赖这个行为，就会出现不兼容问题
  4. 需要再仔细评估

@hengyunabc hengyunabc modified the milestones: 2.7.7, 2.7.8 May 8, 2020
@chickenlj chickenlj mentioned this pull request May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guohao guohao guohao left review comments

@LinShunKang LinShunKang LinShunKang left review comments

Assignees

@chickenlj chickenlj

Labels
status/don’t-merge No plan to merge
Projects
None yet
Milestone
2.7.8
Development

Successfully merging this pull request may close these issues.
4 participants
@chickenlj @guohao @hengyunabc @LinShunKang