Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-5304]fix unstable ut AbstractMetadataReportFactoryTest #5303

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

jasonjoo2010
Copy link
Contributor

@jasonjoo2010 jasonjoo2010 commented Nov 11, 2019

It's unstable under multiple network adapters.

What is the purpose of the change

Make it stable.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@jasonjoo2010 jasonjoo2010 changed the title fix unstable ut AbstractMetadataReportFactoryTest [Dubbo-5304]fix unstable ut AbstractMetadataReportFactoryTest Nov 11, 2019
@jasonjoo2010
Copy link
Contributor Author

And ...... who can tell me what happened to the travis? It failed again and again with different but irrelevant errors.

@jasonjoo2010
Copy link
Contributor Author

related to #5304

@chickenlj chickenlj merged commit c42b0a8 into apache:master Nov 18, 2019
@jasonjoo2010
Copy link
Contributor Author

hi, @chickenlj
Could you spend some time on #4222 ? I have a pr almost finished related on it but need your information.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants