Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize EtcdMetadataReportTest #5088

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Conversation

biyuhao
Copy link
Member

@biyuhao biyuhao commented Sep 19, 2019

What is the purpose of the change

both testStoreProvider() and testStoreConsumer() are unstable, and it is more likely failed in travis.
The assumption we made that the operation should be done in 1s in async mode may fail.

Brief changelog

Bring back testStoreProvider()
Use EtcdMetadataReport in sync mode for UT

Verifying this change

ut pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #5088 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5088      +/-   ##
============================================
+ Coverage     63.89%   64.02%   +0.12%     
- Complexity      451      452       +1     
============================================
  Files           769      769              
  Lines         33261    33261              
  Branches       5235     5249      +14     
============================================
+ Hits          21252    21295      +43     
+ Misses         9571     9530      -41     
+ Partials       2438     2436       -2
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
...che/dubbo/common/compiler/support/JdkCompiler.java 64.54% <0%> (ø) 0% <0%> (ø) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (+0.28%) 31% <0%> (ø) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.75% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.5% <0%> (+0.62%) 29% <0%> (ø) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 66.66% <0%> (+0.79%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 93.75% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...ache/dubbo/common/compiler/support/ClassUtils.java 50.26% <0%> (+1.04%) 0% <0%> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.77% <0%> (+1.13%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java 9.09% <0%> (+1.21%) 0% <0%> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87631aa...b8320ff. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 79c6166 into apache:master Sep 20, 2019
@biyuhao biyuhao deleted the stabilize-ut branch September 29, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants