Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up for pr#4339, remove the space #4591

Merged
merged 1 commit into from
Jul 18, 2019
Merged

follow up for pr#4339, remove the space #4591

merged 1 commit into from
Jul 18, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jul 17, 2019

What is the purpose of the change

follow up for pull request #4339

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4591 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4591      +/-   ##
============================================
- Coverage     64.07%   64.05%   -0.02%     
- Complexity      450      453       +3     
============================================
  Files           768      768              
  Lines         32868    32865       -3     
  Branches       5179     5178       -1     
============================================
- Hits          21061    21053       -8     
- Misses         9400     9404       +4     
- Partials       2407     2408       +1
Impacted Files Coverage Δ Complexity Δ
...o/common/extension/AdaptiveClassCodeGenerator.java 94.95% <ø> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...bbo/registry/support/ProviderConsumerRegTable.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...ng/transport/dispatcher/WrappedChannelHandler.java 44.11% <0%> (-4.54%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.44% <0%> (+0.28%) 32% <0%> (+1%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.21% <0%> (+3.57%) 9% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c88dcb...dd85a60. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants