Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-4570] Fix RegistryProtocol.DestroyableExporter modifiers order #4583

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

AnthonyKot
Copy link
Contributor

What is the purpose of the change

Micro refactoring

Brief changelog

Modifiers order changed

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@AnthonyKot
Copy link
Contributor Author

Build failed with error not related to PR

@AnthonyKot AnthonyKot closed this Jul 16, 2019
@AnthonyKot AnthonyKot reopened this Jul 16, 2019
@AnthonyKot
Copy link
Contributor Author

Last try with Travis

@AnthonyKot AnthonyKot closed this Jul 16, 2019
@AnthonyKot AnthonyKot reopened this Jul 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #4583 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4583      +/-   ##
============================================
+ Coverage     63.18%   63.34%   +0.16%     
- Complexity      448      450       +2     
============================================
  Files           770      770              
  Lines         33015    33015              
  Branches       5204     5218      +14     
============================================
+ Hits          20860    20913      +53     
+ Misses         9745     9704      -41     
+ Partials       2410     2398      -12
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/registry/integration/RegistryProtocol.java 82.69% <ø> (ø) 0 <0> (ø) ⬇️
...che/dubbo/common/compiler/support/JdkCompiler.java 64.54% <0%> (ø) 0% <0%> (ø) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 48.15% <0%> (+0.28%) 31% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.85% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (+0.68%) 0% <0%> (ø) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 66.66% <0%> (+0.79%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 86.45% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...ache/dubbo/common/compiler/support/ClassUtils.java 50.26% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 16% <0%> (ø) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (+1.88%) 0% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82378a1...82434ab. Read the comment docs.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants