fix issue 4328, fix PojoUtils realize issue #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonghaishang
requested changes
Jun 24, 2019
| @@ -129,6 +129,8 @@ public static Object compatibleTypeConvert(Object value, Class<?> type) { | |||
| return BigDecimal.valueOf(number.doubleValue()); | |||
| } else if (type == Date.class) { | |||
| return new Date(number.longValue()); | |||
| } else if (type == boolean.class || type == Boolean.class) { | |||
| return 1 == number.intValue() ? Boolean.TRUE : Boolean.FALSE; | |||
There was a problem hiding this comment.
please change to return number.intValue() != 0:
0 return false, else return true.
There was a problem hiding this comment.
It has been modified
…to return 0 != number.intValue();
|
Why is CI so unstable? @zonghaishang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix https://github.com/apache/dubbo/issues/4328
Brief changelog
Verifying this change
add unit-test PojoUtilsTest.testIntToBoolean
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.