Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: language level migration #3485

Merged
merged 8 commits into from
Feb 15, 2019
Merged

[Enhancement]: language level migration #3485

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5af55e5
use java7 diamond operator
kezhenxu94 Feb 15, 2019
7869df9
replace Collections.sort with List.sort
kezhenxu94 Feb 15, 2019
0a2d300
extract duplicated code blocks
kezhenxu94 Feb 15, 2019
a56cc47
use StandardCharsets.UTF_8
kezhenxu94 Feb 15, 2019
5033f99
use try-with-resources
kezhenxu94 Feb 15, 2019
afc50b0
use java7 diamond operator
kezhenxu94 Feb 15, 2019
7ff0d50
enhance log message
kezhenxu94 Feb 15, 2019
4d8e961
fix unit tests failures
kezhenxu94 Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enhance log message
  • Loading branch information
@kezhenxu94
kezhenxu94 committed Feb 15, 2019
commit 7ff0d509853201aa56260ee71b47f17205ed1df2
4 changes: 2 additions & 2 deletions dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ public static <T> ExtensionLoader<T> getExtensionLoader(Class<T> type) {
throw new IllegalArgumentException("Extension type == null");
}
if (!type.isInterface()) {
throw new IllegalArgumentException("Extension type (" + type + ") is not interface!");
throw new IllegalArgumentException("Extension type (" + type + ") is not an interface!");
}
if (!withExtensionAnnotation(type)) {
throw new IllegalArgumentException("Extension type (" + type +
") is not extension, because WITHOUT @" + SPI.class.getSimpleName() + " Annotation!");
") is not an extension, because it is NOT annotated with @" + SPI.class.getSimpleName() + "!");
}

ExtensionLoader<T> loader = (ExtensionLoader<T>) EXTENSION_LOADERS.get(type);
Expand Down