Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize getExtensionClass method. #2788

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

carryxyh
Copy link
Member

@carryxyh carryxyh commented Nov 15, 2018

Optimize getExtensionClass method.
Just return the class instead of throwing exception.

org.apache.dubbo.common.extension.ExtensionLoader#getExtensionClass just has one caller that is hasExtension. So it will not effect other logic.

Just return the class instead of throwing exception.
@codecov-io
Copy link

Codecov Report

Merging #2788 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
- Coverage    63.6%   63.49%   -0.12%     
==========================================
  Files         577      577              
  Lines       25935    25930       -5     
  Branches     4544     4544              
==========================================
- Hits        16495    16463      -32     
- Misses       7283     7302      +19     
- Partials     2157     2165       +8
Impacted Files Coverage Δ
...apache/dubbo/common/extension/ExtensionLoader.java 80.44% <100%> (-0.2%) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 54.11% <0%> (-8.24%) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 85.71% <0%> (-3.58%) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 65.94% <0%> (-2.17%) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 81.25% <0%> (-1.93%) ⬇️
...ache/dubbo/remoting/transport/mina/MinaClient.java 56.92% <0%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a6511...0242787. Read the comment docs.

@carryxyh
Copy link
Member Author

@beiwei30
Simple pr. Would u pls give a review?

@ralf0131 ralf0131 self-requested a review December 6, 2018 14:46
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 628ad77 into apache:master Dec 6, 2018
@carryxyh carryxyh deleted the optimize-hasExtension branch December 7, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants