Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决了代码规范问题:在if/else/for/while/do语句中必须使用大括号 #2528

Merged
merged 1 commit into from Sep 21, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2018

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2528 into master will decrease coverage by 0.05%.
The diff coverage is 15.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2528      +/-   ##
============================================
- Coverage     55.01%   54.96%   -0.06%     
+ Complexity     5280     5276       -4     
============================================
  Files           573      573              
  Lines         25490    25502      +12     
  Branches       4526     4526              
============================================
- Hits          14024    14017       -7     
- Misses         9370     9385      +15     
- Partials       2096     2100       +4
Impacted Files Coverage Δ Complexity Δ
.../exchange/support/header/HeaderExchangeServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 62.79% <0%> (ø) 12 <0> (ø) ⬇️
...exchange/support/header/HeaderExchangeChannel.java 79.16% <0%> (-4.35%) 35 <1> (ø)
.../dubbo/registry/integration/RegistryDirectory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-5.08%) 22 <0> (-1)
.../rpc/cluster/router/condition/ConditionRouter.java 71.64% <0%> (ø) 33 <0> (ø) ⬇️
...pc/cluster/loadbalance/LeastActiveLoadBalance.java 70.58% <0%> (ø) 6 <0> (ø) ⬇️
...org/apache/dubbo/registry/redis/RedisRegistry.java 32.76% <0%> (ø) 16 <0> (ø) ⬇️
...org/apache/dubbo/registry/dubbo/DubboRegistry.java 46.15% <0%> (ø) 8 <1> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 67.91% <0%> (-0.26%) 64 <3> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd60e58...12c5b23. Read the comment docs.

@diecui1202
Copy link

good point.

@diecui1202 diecui1202 merged commit 18dee4e into apache:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants