Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug for travis #2481

Merged
merged 1 commit into from
Sep 11, 2018
Merged

debug for travis #2481

merged 1 commit into from
Sep 11, 2018

Conversation

diecui1202
Copy link

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Sep 11, 2018

Codecov Report

Merging #2481 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #2481     +/-   ##
==========================================
- Coverage     55.09%     55%   -0.1%     
+ Complexity     5270    5266      -4     
==========================================
  Files           573     573             
  Lines         25446   25446             
  Branches       4518    4518             
==========================================
- Hits          14019   13996     -23     
- Misses         9335    9357     +22     
- Partials       2092    2093      +1
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 7% <0%> (-1%)
...onfig/spring/extension/SpringExtensionFactory.java 75% <0%> (-10.72%) 10% <0%> (ø)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 55.6% <0%> (-1.73%) 35% <0%> (-3%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 67.41% <0%> (-1.13%) 62% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 71.42% <0%> (+3.57%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a86d61...13b1739. Read the comment docs.

@diecui1202 diecui1202 merged commit 7e5f080 into apache:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants