-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-2187] Use CompletetableFuture to rewrite the embedded ListenableFuture #2213
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
aa5fa4b
use CompletetableFuture to rewrite the embedded ListenableFuture
dengwanghua 313318a
Refine previous modifications
242d98c
Refine previous modifications
55cb672
Refine previous modifications in CompletableFutureTaskTest
4fbd2d3
Refine previous modifications in CompletableFutureTaskTest
f6b455e
Refine previous modifications in CompletableFutureTaskTest
6b87f44
deal exception
df72282
deal exception
651977a
deal import
02201c5
deal exception
9e8d772
deal import
217f19b
deal exception
2339692
Reformat code & fix bugs
chickenlj b805808
Merge remote-tracking branch 'dengwanghua/1_2187' into completablefut…
chickenlj 2283896
Reformat code
chickenlj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deal exception
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should handle the possible Exceptions that may come up here.