Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatible class for config #2169 #2170

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

diecui1202
Copy link

What is the purpose of the change

add compatible class for config

Brief changelog

dubbo-compatible

Verifying this change

add unit tests

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2170 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2170      +/-   ##
===========================================
- Coverage      54.3%   54.3%   -0.01%     
- Complexity     5111    5120       +9     
===========================================
  Files           559     569      +10     
  Lines         24981   25016      +35     
  Branches       4453    4453              
===========================================
+ Hits          13566   13584      +18     
- Misses         9380    9394      +14     
- Partials       2035    2038       +3
Impacted Files Coverage Δ Complexity Δ
...in/java/com/alibaba/dubbo/config/MethodConfig.java 100% <100%> (ø) 1 <1> (?)
.../java/com/alibaba/dubbo/config/ConsumerConfig.java 100% <100%> (ø) 1 <1> (?)
.../java/com/alibaba/dubbo/config/ArgumentConfig.java 100% <100%> (ø) 1 <1> (?)
...va/com/alibaba/dubbo/config/ApplicationConfig.java 100% <100%> (ø) 2 <2> (?)
.../java/com/alibaba/dubbo/config/ProtocolConfig.java 33.33% <33.33%> (ø) 1 <1> (?)
...java/com/alibaba/dubbo/config/ReferenceConfig.java 50% <50%> (ø) 1 <1> (?)
...n/java/com/alibaba/dubbo/config/MonitorConfig.java 50% <50%> (ø) 1 <1> (?)
...n/java/com/alibaba/dubbo/config/ServiceConfig.java 50% <50%> (ø) 1 <1> (?)
...in/java/com/alibaba/dubbo/config/ModuleConfig.java 50% <50%> (ø) 1 <1> (?)
.../java/com/alibaba/dubbo/config/RegistryConfig.java 66.66% <66.66%> (ø) 2 <2> (?)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c904589...fabc941. Read the comment docs.

@diecui1202 diecui1202 merged commit 5de6c76 into apache:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants