Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2013] Enable thread pool config on Consumer side #2119

Closed
wants to merge 2 commits into from

Conversation

cvictory
Copy link
Contributor

What is the purpose of the change

Add configuration of consumer thread pool number.

Brief changelog

Add configuration of consumer thread pool number.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2119 into 2.6.x will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #2119      +/-   ##
============================================
+ Coverage     47.35%   47.35%   +<.01%     
- Complexity     4265     4266       +1     
============================================
  Files           557      557              
  Lines         24369    24374       +5     
  Branches       4330     4331       +1     
============================================
+ Hits          11540    11543       +3     
+ Misses        11040    11039       -1     
- Partials       1789     1792       +3
Impacted Files Coverage Δ Complexity Δ
.../java/com/alibaba/dubbo/config/ConsumerConfig.java 75% <ø> (-9.62%) 7 <0> (+1)
...java/com/alibaba/dubbo/config/ReferenceConfig.java 47.98% <0%> (-0.36%) 36 <0> (ø)
...va/com/alibaba/dubbo/config/DubboShutdownHook.java 43.47% <0%> (-30.44%) 5% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-8.34%) 3% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 78.67% <0%> (-1.48%) 29% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 15% <0%> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 83.33% <0%> (+11.11%) 7% <0%> (+1%) ⬆️
...aba/dubbo/remoting/transport/mina/MinaChannel.java 53.52% <0%> (+11.26%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bad2e...9a4bd01. Read the comment docs.

@chickenlj
Copy link
Contributor

We have received a PR #2114 solving this problem, let's focus on #2114.

Thanks

@chickenlj chickenlj closed this Jul 25, 2018
@chickenlj chickenlj changed the title #2013 [Dubbo-2013] Enable thread pool config on Consumer side Jul 26, 2018
@cvictory cvictory deleted the 2.6.x branch September 30, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants