Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchance test coverage of dubbo cluster module #1885

Merged
merged 17 commits into from
Jun 7, 2018
Merged

Enchance test coverage of dubbo cluster module #1885

merged 17 commits into from
Jun 7, 2018

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Jun 4, 2018

What is the purpose of the change

#1679 Enhance the test coverage part-1 : dubbo-cluster module

Brief changelog

add some test case

Verifying this change

ci pass

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #1885 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1885      +/-   ##
===========================================
+ Coverage     48.16%   48.5%   +0.34%     
- Complexity     4347    4387      +40     
===========================================
  Files           558     558              
  Lines         24364   24362       -2     
  Branches       4323    4323              
===========================================
+ Hits          11736   11818      +82     
+ Misses        10791   10705      -86     
- Partials       1837    1839       +2
Impacted Files Coverage Δ Complexity Δ
...cluster/loadbalance/ConsistentHashLoadBalance.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rpc/cluster/configurator/AbstractConfigurator.java 42.55% <ø> (+1.73%) 8 <0> (ø) ⬇️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (ø)
...libaba/dubbo/rpc/cluster/merger/MergerFactory.java 73.91% <0%> (ø) 6% <0%> (ø) ⬇️
...baba/dubbo/remoting/transport/mina/MinaClient.java 59.37% <0%> (+1.56%) 9% <0%> (+1%) ⬆️
...bo/remoting/transport/netty/NettyCodecAdapter.java 54.68% <0%> (+1.56%) 3% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+3%) ⬆️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 62.79% <0%> (+6.97%) 12% <0%> (+2%) ⬆️
...a/dubbo/rpc/cluster/directory/StaticDirectory.java 60.71% <0%> (+32.14%) 10% <0%> (+4%) ⬆️
...om/alibaba/dubbo/rpc/cluster/merger/MapMerger.java 62.5% <0%> (+50%) 3% <0%> (+2%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4974c6...e3d2484. Read the comment docs.

@lovepoem lovepoem requested a review from beiwei30 June 7, 2018 07:37
@lovepoem lovepoem merged commit 2826666 into apache:master Jun 7, 2018
@lovepoem lovepoem deleted the enchance_test_coverage_of_dubbo_cluster_module branch June 23, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants