-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enchance test coverage of dubbo cluster module #1885
Merged
lovepoem
merged 17 commits into
apache:master
from
lovepoem:enchance_test_coverage_of_dubbo_cluster_module
Jun 7, 2018
Merged
Enchance test coverage of dubbo cluster module #1885
lovepoem
merged 17 commits into
apache:master
from
lovepoem:enchance_test_coverage_of_dubbo_cluster_module
Jun 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_coverage_of_dubbo_cluster_module
…_coverage_of_dubbo_cluster_module
…_coverage_of_dubbo_cluster_module
…_coverage_of_dubbo_cluster_module
…_coverage_of_dubbo_cluster_module
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
===========================================
+ Coverage 48.16% 48.5% +0.34%
- Complexity 4347 4387 +40
===========================================
Files 558 558
Lines 24364 24362 -2
Branches 4323 4323
===========================================
+ Hits 11736 11818 +82
+ Misses 10791 10705 -86
- Partials 1837 1839 +2
Continue to review full report at Codecov.
|
…_coverage_of_dubbo_cluster_module
…_coverage_of_dubbo_cluster_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#1679 Enhance the test coverage part-1 : dubbo-cluster module
Brief changelog
add some test case
Verifying this change
ci pass