fix(common): close input stream in ConfigUtils#loadProperties fallback#16116
Open
LouisLau-art wants to merge 1 commit intoapache:3.3from
Open
fix(common): close input stream in ConfigUtils#loadProperties fallback#16116LouisLau-art wants to merge 1 commit intoapache:3.3from
LouisLau-art wants to merge 1 commit intoapache:3.3from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16116 +/- ##
============================================
- Coverage 60.80% 60.79% -0.01%
+ Complexity 11753 11751 -2
============================================
Files 1953 1953
Lines 89118 89120 +2
Branches 13444 13445 +1
============================================
- Hits 54187 54184 -3
+ Misses 29367 29366 -1
- Partials 5564 5570 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes an input stream resource leak in
ConfigUtils.loadProperties(...)whenallowMultiFile == falseand fallback loading path is used.Previously the code called:
properties.load(ClassUtils.getClassLoader().getResourceAsStream(fileName));This could leave the stream unclosed. The fallback now uses try-with-resources and null-checks the stream before loading.
Why
This addresses issue #16098 and keeps resource handling consistent with other load paths in
ConfigUtils.Verification
./mvnw -pl dubbo-common -Dtest=ConfigUtilsTest test -DskipITsTests run: 25, Failures: 0, Errors: 0, Skipped: 1)Fixes #16098