chore: Maven version update (3.9.9 -->> 3.9.11) #15786
Open
+220
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15786 +/- ##
============================================
+ Coverage 60.76% 60.78% +0.01%
- Complexity 11696 11699 +3
============================================
Files 1938 1938
Lines 88679 88679
Branches 13386 13386
============================================
+ Hits 53885 53901 +16
+ Misses 29254 29246 -8
+ Partials 5540 5532 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@heliang666s and @zrlw: PTAL |
AlbumenJ
requested changes
Nov 28, 2025
Comment on lines
-1
to
-16
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. |
Author
There was a problem hiding this comment.
@AlbumenJ Maven team decided to remove license out of maven-wrapper.properties; their rationale: both script files (mvnw and mvnw.cmd) contain license and hence maven-wrapper.properties licence reference is kind of redundant: apache/maven-wrapper#323
LMK what do you think (i.e. which option suits you).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
How was this change performed ?
./mvnw wrapper:wrapper -N -Dtype=bin -Dmaven=3.9.11Related links (maven release notes):
ℹ️ Note: the checklist template was removed given the fact that PR is simple and self-explanatory (but I can provide more details in case maintainers insist).