Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1539, change log method #1578

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix #1539, change log method #1578

merged 1 commit into from
Apr 10, 2018

Conversation

diecui1202
Copy link

@diecui1202 diecui1202 commented Apr 10, 2018

What is the purpose of the change

Just fix hand-writing error for warn log

Brief changelog

XX

Verifying this change

All unit test are pass.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #1578 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1578      +/-   ##
============================================
+ Coverage     34.52%   34.53%   +<.01%     
- Complexity     3684     3685       +1     
============================================
  Files           621      621              
  Lines         30875    30875              
  Branches       5448     5448              
============================================
+ Hits          10661    10663       +2     
  Misses        18376    18376              
+ Partials       1838     1836       -2
Impacted Files Coverage Δ Complexity Δ
...pc/cluster/support/wrapper/MockClusterInvoker.java 62.5% <100%> (ø) 10 <0> (ø) ⬇️
...a/dubbo/remoting/transport/netty/NettyChannel.java 62.5% <0%> (-3.75%) 20% <0%> (-1%)
...ba/dubbo/remoting/transport/netty/NettyServer.java 70.9% <0%> (+3.63%) 9% <0%> (+1%) ⬆️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 55.69% <0%> (+3.79%) 13% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25d462...50f72c0. Read the comment docs.

@mercyblitz mercyblitz merged commit d80a42c into apache:master Apr 10, 2018
@chickenlj chickenlj added this to the 2.6.2 milestone Apr 24, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants