Skip to content

Fixed flaky test: org.apache.dubbo.common.bytecode.WrapperTest.est_getMethodNames_ContainExtendsParentMethods #15683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zrlw merged 11 commits into from
Sep 18, 2025
Merged

Fixed flaky test: org.apache.dubbo.common.bytecode.WrapperTest.est_getMethodNames_ContainExtendsParentMethods #15683

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fa2317d
Create test-flaky.yml
Hussain-Safwan Aug 29, 2025
9ef029f
Update test-flaky.yml
Hussain-Safwan Aug 29, 2025
6d68178
Delete .github/workflows/test-flaky.yml
Hussain-Safwan Aug 29, 2025
6b2e4ad
Create test-flaky.yml
Hussain-Safwan Aug 29, 2025
faa416a
Update test-flaky.yml
Hussain-Safwan Aug 29, 2025
08decd1
Update test-flaky.yml
Hussain-Safwan Aug 29, 2025
e826d85
added nondex plugin installation
Hussain-Safwan Aug 29, 2025
64bb1b2
fixed test run command
Hussain-Safwan Aug 29, 2025
41aa20a
[Test-Fixed] flaky test:test_getMethodNames_ContainExtendsParentMetho…
Hussain-Safwan Aug 30, 2025
6b6b3f8
unused file removed
Sep 10, 2025
77bc1c3
Merge branch '3.3' into fix-flaky-test
zrlw Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions dubbo-common/src/test/java/org/apache/dubbo/common/bytecode/WrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

import org.apache.dubbo.common.utils.ClassUtils;

import java.util.Arrays;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
Expand Down Expand Up @@ -179,9 +181,14 @@ void test_getDeclaredMethodNames_ContainExtendsParentMethods() throws Exception

@Test
void test_getMethodNames_ContainExtendsParentMethods() throws Exception {
assertArrayEquals(
new String[] {"hello", "world"}, Wrapper.getWrapper(Son.class).getMethodNames());
assertArrayEquals(new String[] {"hello", "world"}, ClassUtils.getMethodNames(Son.class));
String[] methodNamesFromWrapepr = Wrapper.getWrapper(Son.class).getMethodNames();
String[] methodNamesFromClassUtils = ClassUtils.getMethodNames(Son.class);

Arrays.sort(methodNamesFromWrapepr);
Arrays.sort(methodNamesFromClassUtils);

assertArrayEquals(new String[] {"hello", "world"}, methodNamesFromWrapepr);
assertArrayEquals(new String[] {"hello", "world"}, methodNamesFromClassUtils);
}

@Test
Expand Down
Loading