Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing @Override to classes #1553

Merged
merged 26 commits into from
Apr 21, 2018
Merged

add missing @Override to classes #1553

merged 26 commits into from
Apr 21, 2018

Conversation

leyou240
Copy link
Contributor

@leyou240 leyou240 commented Apr 4, 2018

What is the purpose of the change

add missing @OverRide to classes

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

翁德志 and others added 25 commits December 14, 2017 03:39
# Conflicts:
#	dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/RouteRuleTest.java
# Conflicts:
#	dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/RouteRuleTest.java
@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #1553 into master will increase coverage by 0.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1553     +/-   ##
========================================
+ Coverage   30.69%   31.6%   +0.9%     
========================================
  Files         682     682             
  Lines       32174   33048    +874     
  Branches     6294    6597    +303     
========================================
+ Hits         9877   10446    +569     
- Misses      20591   20747    +156     
- Partials     1706    1855    +149
Impacted Files Coverage Δ
...ing/transport/dispatcher/ChannelEventRunnable.java 83.33% <ø> (ø) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 0% <ø> (ø) ⬆️
...aba/dubbo/rpc/cluster/support/FailfastCluster.java 0% <ø> (ø) ⬆️
...aba/dubbo/remoting/p2p/support/MulticastGroup.java 0% <ø> (ø) ⬆️
...ba/dubbo/common/io/UnsafeByteArrayInputStream.java 0% <ø> (ø) ⬆️
...ba/dubbo/registry/multicast/MulticastRegistry.java 43.51% <ø> (-0.89%) ⬇️
...ubbo/remoting/transport/mina/MinaCodecAdapter.java 59.01% <ø> (ø) ⬆️
...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java 26.08% <ø> (+0.28%) ⬆️
...ubbo/remoting/transport/grizzly/GrizzlyServer.java 0% <ø> (ø) ⬆️
...aba/dubbo/remoting/http/jetty/JettyHttpServer.java 79.48% <ø> (-2.1%) ⬇️
... and 572 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2af69...638e495. Read the comment docs.

@leyou240
Copy link
Contributor Author

leyou240 commented Apr 9, 2018

aim to #1239

@lovepoem lovepoem requested review from chickenlj and removed request for chickenlj April 11, 2018 09:56
@lovepoem lovepoem requested review from qinliujie and chickenlj April 11, 2018 09:56
@ralf0131
Copy link
Contributor

Looks good to me, thanks for the pull request!

@ralf0131 ralf0131 merged commit 60e3b19 into apache:master Apr 21, 2018
@chickenlj chickenlj added this to the 2.6.2 milestone Apr 24, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants