Skip to content

Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux. #15371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 2 commits into from
May 16, 2025
Merged

Fix ClassCastException caused by overly broad type check in Dubbo tracing integration with Spring WebFlux. #15371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eabf13
Fix ClassCastException caused by overly broad type check in Dubbo tra…
May 12, 2025
a22851a
Merge branch '3.3' into webflux
songxiaosheng May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../src/main/java/org/apache/dubbo/tracing/handler/DubboClientTracingObservationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import io.micrometer.observation.Observation;
import io.micrometer.observation.ObservationHandler;
import io.micrometer.observation.transport.SenderContext;
import io.micrometer.tracing.Tracer;

public class DubboClientTracingObservationHandler<T extends DubboClientContext> implements ObservationHandler<T> {
Expand All @@ -35,6 +34,6 @@ public void onScopeOpened(T context) {}

@Override
public boolean supportsContext(Observation.Context context) {
return context instanceof SenderContext;
return context instanceof DubboClientContext;
}
}
3 changes: 1 addition & 2 deletions .../src/main/java/org/apache/dubbo/tracing/handler/DubboServerTracingObservationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import io.micrometer.observation.Observation;
import io.micrometer.observation.ObservationHandler;
import io.micrometer.observation.transport.ReceiverContext;
import io.micrometer.tracing.TraceContext;
import io.micrometer.tracing.Tracer;

Expand All @@ -46,6 +45,6 @@ public void onScopeOpened(T context) {

@Override
public boolean supportsContext(Observation.Context context) {
return context instanceof ReceiverContext;
return context instanceof DubboServerContext;
}
}
Loading