fix: toCommaDelimitedString returns "null,null" when inputs are null#15322
fix: toCommaDelimitedString returns "null,null" when inputs are null#15322ankitshokeen wants to merge 17 commits intoapache:3.3from
Conversation
…tch expected behavior
Codecov Report❌ Patch coverage is Please upload reports for the commit 0a2d0e3 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15322 +/- ##
=============================================
- Coverage 60.76% 35.61% -25.15%
+ Complexity 10918 10882 -36
=============================================
Files 1886 1886
Lines 86127 86163 +36
Branches 12903 12909 +6
=============================================
- Hits 52334 30688 -21646
- Misses 28332 51004 +22672
+ Partials 5461 4471 -990
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AlbumenJ @songxiaosheng @JunJieLiu51520 please review this PR |
|
Why are there so many unrelated changes? |
Invalid PR, please ignore |
Issue
#15321
What is the purpose of the change?
This change corrects the behavior of StringUtils.toCommaDelimitedString(String one, String... others) to return null when either argument is null, as described in its Javadoc. Previously, the method would return a string like "null,null", which could lead to misleading outputs and test failures. This update ensures consistency between the method's implementation and its documented contract.
Checklist