Skip to content

[3.3] optimized testExporterThreadpoolName by starting dispatcher thread directly #15241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 1 commit into from
Mar 17, 2025
Merged

[3.3] optimized testExporterThreadpoolName by starting dispatcher thread directly #15241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...us/src/test/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricsThreadPoolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ void testExporterThreadpoolName() {
PrometheusMetricsReporter reporter = new PrometheusMetricsReporter(metricsConfig.toUrl(), applicationModel);
reporter.init();
exportHttpServer(reporter, port);
try {
Thread.sleep(5000);
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
if (metricsConfig.getEnableThreadpool()) {
metricsCollector.registryDefaultSample();
}
Expand Down Expand Up @@ -135,8 +130,8 @@ private void exportHttpServer(PrometheusMetricsReporter reporter, int port) {
os.write(response.getBytes());
}
});
Thread httpServerThread = new Thread(prometheusExporterHttpServer::start);
httpServerThread.start();
// start ServerImpl dispatcher thread.
prometheusExporterHttpServer.start();
} catch (IOException e) {
throw new RuntimeException(e);
}
Expand Down
Loading