autoconfiguration virtual-thread-pool#15220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15220 +/- ##
============================================
- Coverage 60.78% 60.77% -0.01%
- Complexity 10890 10893 +3
============================================
Files 1885 1885
Lines 86072 86077 +5
Branches 12892 12894 +2
============================================
- Hits 52319 52317 -2
- Misses 28306 28315 +9
+ Partials 5447 5445 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As far as I know, Virtual Threads is a new feature introduced after JDK 21, and Spring Boot added support for it starting from version 3.2. Should we add this configuration in dubbo-spring-boot-3? |
but we don‘t have |
|
|
||
| private void setDubboVirtualThreadsProperty(Environment environment, Map<String, Object> defaultProperties) { | ||
| String virtualEnabled = environment.getProperty(SPRING_THREAD_POOL_PROPERTY); | ||
| if (StringUtils.hasLength(virtualEnabled)) { |
I think it's pretty simple at the moment, consider refactoring and pulling it out later when there's more configurations, |
What is the purpose of the change?
fix #15158
Checklist