[3.3] Retry connect to provider server by catching ClosedChannelException#15209
Merged
AlbumenJ merged 1 commit intoapache:3.3from Mar 12, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15209 +/- ##
============================================
+ Coverage 60.76% 60.77% +0.01%
- Complexity 10886 10892 +6
============================================
Files 1885 1885
Lines 86071 86082 +11
Branches 12892 12894 +2
============================================
+ Hits 52298 52316 +18
+ Misses 28326 28314 -12
- Partials 5447 5452 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7a92b27 to
cf3f3bf
Compare
cf3f3bf to
b9a14d5
Compare
AlbumenJ
requested changes
Mar 11, 2025
| if (logger.isInfoEnabled()) { | ||
| logger.info("Close old netty channel " + oldChannel + " on create new netty channel " | ||
| + newChannel); | ||
| while (true) { |
Member
There was a problem hiding this comment.
we should limit the maximum times here
zrlw
commented
Mar 11, 2025
|
|
||
| if (cause instanceof ClosedChannelException) { | ||
| // Netty3.2.10 ClosedChannelException issue, see https://github.com/netty/netty/issues/138 | ||
| connectTimeout = deadline - System.currentTimeMillis(); |
Contributor
Author
There was a problem hiding this comment.
@AlbumenJ
connectTimeout will be recalculated at here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
try to fix #15191
@AlbumenJ
Checklist