Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Optimized getWrapper of bytecode Wrapper and DemoServiceImpl of dubbo-remoting-netty4 #15164

Open
wants to merge 2 commits into
base: 3.3
Choose a base branch
from

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Feb 22, 2025

What is the purpose of the change?

try to fix #15160

  1. cached wrapper as soon as possible.
  2. using logger.info instead of System.out.println to remove synchronized codes
    public void println(String x) {
        synchronized (this) {
            print(x);
            newLine();
        }
    }

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (cedc583) to head (217cd51).

Files with missing lines Patch % Lines
...java/org/apache/dubbo/common/bytecode/Wrapper.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15164   +/-   ##
=========================================
  Coverage     60.71%   60.72%           
- Complexity    10877    10878    +1     
=========================================
  Files          1884     1884           
  Lines         86055    86056    +1     
  Branches      12894    12894           
=========================================
+ Hits          52247    52254    +7     
+ Misses        28353    28345    -8     
- Partials       5455     5457    +2     
Flag Coverage Δ
integration-tests 33.08% <33.33%> (-0.01%) ⬇️
samples-tests 29.19% <33.33%> (-0.01%) ⬇️
unit-tests 58.83% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrlw zrlw changed the title [3.3] Optimized getWrapper of bytecode Wrapper [3.3] Optimized getWrapper of bytecode Wrapper and DemoServiceImpl of dubbo-remoting-netty4 Feb 23, 2025
@zrlw zrlw force-pushed the 3.3-Optimized-byteCodeWrapper branch from df82aea to 217cd51 Compare February 23, 2025 11:56
@zrlw
Copy link
Contributor Author

zrlw commented Feb 23, 2025

@AlbumenJ
PTAL
i don't know this pr whether fixed the issue or not asBuild and Test Scheduled On 3.3 could not be triggered on pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Build and Test Scheduled On 3.3 might be always failed since 'feat: remove useless dependency(#15125)'
2 participants