Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-remoting-zookeeper-curator5 module remove dubbo-test-check and dubbo-test-common #15082

Merged

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@Stellar1999 Stellar1999 force-pushed the Remoting_zookeeper_remove_test_common branch from 357ddd5 to cc962b9 Compare February 7, 2025 14:53
@Stellar1999 Stellar1999 marked this pull request as ready for review February 7, 2025 14:54
@Stellar1999 Stellar1999 force-pushed the Remoting_zookeeper_remove_test_common branch from cc962b9 to a10cc18 Compare February 7, 2025 15:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.73%. Comparing base (628dcbf) to head (a10cc18).
Report is 33 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15082      +/-   ##
============================================
- Coverage     60.76%   60.73%   -0.04%     
+ Complexity    10863    10861       -2     
============================================
  Files          1882     1882              
  Lines         86007    86009       +2     
  Branches      12886    12887       +1     
============================================
- Hits          52263    52237      -26     
- Misses        28301    28326      +25     
- Partials       5443     5446       +3     
Flag Coverage Δ
integration-tests 33.04% <ø> (+0.06%) ⬆️
samples-tests 29.19% <ø> (-0.03%) ⬇️
unit-tests 58.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stellar1999
Copy link
Contributor Author

@CrazyHZM PTAL

@CrazyHZM CrazyHZM merged commit d8f5406 into apache:3.3 Feb 10, 2025
19 checks passed
@zrlw
Copy link
Contributor

zrlw commented Feb 13, 2025

dubbo-test-check otherwise test failure:

[dubbo-samples-configcenter-apollo:1/1] TEST FAILURE: Run tests timeout, version: -Ddubbo.version=3.3.4-SNAPSHOT -Dspring.version=5.3.24 -Djava.version=8, please check logs: /home/runner/work/dubbo/dubbo/3-extensions/configcenter/dubbo-samples-configcenter-apollo/target/logs

@zrlw
Copy link
Contributor

zrlw commented Feb 13, 2025

why adding dubbo-test-check to dubbo-remoting-api? it seemed that all modules which need dubbo-test-check already set it's dependency in them pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants