Skip to content

Fix dead loop in onNext #14917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 1 commit into from
Nov 20, 2024
Merged

Fix dead loop in onNext #14917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...p12/src/main/java/org/apache/dubbo/remoting/http12/AbstractServerHttpChannelObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ public final void onNext(Object data) {
doOnNext(data);
} catch (Throwable t) {
LOGGER.warn(INTERNAL_ERROR, "", "", "Error while doOnNext", t);
onError(t);
Throwable throwable = t;
try {
doOnError(throwable);
} catch (Throwable t1) {
LOGGER.warn(INTERNAL_ERROR, "", "", "Error while doOnError, original error: " + throwable, t1);
throwable = t1;
}
onCompleted(throwable);
}
}

Expand All @@ -105,7 +112,6 @@ public final void onError(Throwable throwable) {
if (closed) {
return;
}

try {
throwable = customizeError(throwable);
if (throwable == null) {
Expand All @@ -122,7 +128,6 @@ public final void onError(Throwable throwable) {
LOGGER.warn(INTERNAL_ERROR, "", "", "Error while doOnError, original error: " + throwable, t);
throwable = t;
}

onCompleted(throwable);
}

Expand Down