Skip to content

Comments

correctly validate service-name-mapping parameter#14905

Merged
AlbumenJ merged 1 commit intoapache:3.3from
aruato:validate-service-name-mapping
Nov 20, 2024
Merged

correctly validate service-name-mapping parameter#14905
AlbumenJ merged 1 commit intoapache:3.3from
aruato:validate-service-name-mapping

Conversation

@aruato
Copy link
Contributor

@aruato aruato commented Nov 18, 2024

What is the purpose of the change?

The service-name-mapping is set as follows:

if (SERVICE_REGISTRY_PROTOCOL.equals(registryURL.getProtocol())) {
url = url.addParameterIfAbsent(SERVICE_NAME_MAPPING_KEY, "true");
}

The validation logic should be consistent with the setting logic.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@AlbumenJ AlbumenJ merged commit 9b673de into apache:3.3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants