Skip to content

Fix http3 negotiation failed #14901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 1 commit into from
Nov 20, 2024
Merged

Fix http3 negotiation failed #14901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions dubbo-distribution/dubbo-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,6 @@
<version>${project.version}</version>
<type>pom</type>
</dependency>
<dependency>
Copy link
Contributor Author

@oxsean oxsean Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication.

<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-actuator-autoconfigure</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-autoconfigure-compatible</artifactId>
Expand Down
10 changes: 7 additions & 3 deletions ...e/src/main/java/org/apache/dubbo/rpc/protocol/tri/h3/negotiation/NegotiateClientCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ public CompletableFuture<String> start(URL url) {
CompletableFuture<String> future = new CompletableFuture<>();
try {
Channel channel = connectionClient.getChannel(true);
if (channel == null) {
future.completeExceptionally(new IllegalStateException("Channel is null"));
return future;
}
Http2StreamChannelBootstrap bootstrap = new Http2StreamChannelBootstrap(channel);
bootstrap.handler(new ChannelInboundHandlerAdapter() {
@Override
Expand Down Expand Up @@ -112,9 +116,6 @@ private static final class Listener implements H2TransportListener {

@Override
public void onHeader(Http2Headers headers, boolean endStream) {
if (endStream) {
return;
}
CharSequence line = headers.status();
if (line != null) {
HttpResponseStatus status = HttpResponseStatus.parseLine(line);
Expand All @@ -124,6 +125,9 @@ public void onHeader(Http2Headers headers, boolean endStream) {
return;
}
}
if (endStream) {
return;
}
executor.execute(() -> future.completeExceptionally(new RuntimeException("Status: " + line)));
}

Expand Down
5 changes: 0 additions & 5 deletions dubbo-test/dubbo-dependencies-all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,6 @@
<artifactId>dubbo-spring-boot-autoconfigure</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-actuator-autoconfigure</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-autoconfigure-compatible</artifactId>
Expand Down