Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:tcp connection window size split from stream connection window size for 3.2 #14664

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

JunJieLiu51520
Copy link
Contributor

What is the purpose of the change

see issue #14635

Brief changelog

details can see io.netty.handler.codec.http2.Http2FrameCodec#tryExpandConnectionFlowControlWindow

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@JunJieLiu51520
Copy link
Contributor Author

details refer to io.netty.handler.codec.http2.Http2FrameCodec#tryExpandConnectionFlowControlWindow

@JunJieLiu51520
Copy link
Contributor Author

JunJieLiu51520 commented Sep 11, 2024

@oxsean i'm sorry to say that because some reason i have to recreate a pr
PTAL

@JunJieLiu51520 JunJieLiu51520 changed the title fix:tcp connection window size split from stream connection window size fix:tcp connection window size split from stream connection window size for 3.2 Sep 11, 2024
@@ -20,6 +20,9 @@
import org.apache.dubbo.common.config.ConfigurationUtils;
import org.apache.dubbo.rpc.model.ApplicationModel;

import java.util.ArrayDeque;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why import ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like code formatting

@JunJieLiu51520
Copy link
Contributor Author

@EarthChen PTAL

Copy link
Collaborator

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oxsean oxsean merged commit ddb3fba into apache:3.2 Sep 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants