Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-monitor] change monitor log level #1443

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Conversation

VictorZeng
Copy link
Contributor

What is the purpose of the change

fix #1439

Brief changelog

change monitor log level to Debug

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2018

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

Codecov Report

Merging #1443 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   31.59%   31.56%   -0.03%     
==========================================
  Files         682      682              
  Lines       33035    33034       -1     
  Branches     6592     6591       -1     
==========================================
- Hits        10436    10428       -8     
- Misses      20748    20753       +5     
- Partials     1851     1853       +2
Impacted Files Coverage Δ
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 73.83% <100%> (+0.68%) ⬆️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) ⬇️
...ba/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...bo/remoting/transport/netty/NettyCodecAdapter.java 55.22% <0%> (-1.5%) ⬇️
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.97% <0%> (-1.45%) ⬇️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22f56...915fe85. Read the comment docs.

@VictorZeng VictorZeng mentioned this pull request Mar 9, 2018
@kimmking
Copy link
Member

kimmking commented Mar 9, 2018

@VictorZeng :)

@ralf0131
Copy link
Contributor

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit 98a906a into apache:master Apr 21, 2018
@chickenlj chickenlj added this to the 2.6.2 milestone Apr 24, 2018
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo monitor log
6 participants