Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple rest useTrailingSlashMatch useSuffixPatternMatch support #14292

Closed
wants to merge 1 commit into from

Conversation

heliang666s
Copy link
Contributor

@heliang666s heliang666s commented Jun 6, 2024

What is the purpose of the change

Triple rest useTrailingSlashMatch useSuffixPatternMatch support
#14036

Brief changelog

add tow method to support it

Verifying this change

No

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Jun 6, 2024

Copy link
Collaborator

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. RestConfig is not being read.
  2. Directly removing the suffix and trailing slash is not the correct way to handle it. If there are multiple mappings, full match should be prioritized. The correct logic should be:
    a. First, try to match the original path.
    b. If it does not match and suffix matching is allowed and a suffix is present, try removing the suffix and matching.
    c. If it does not match and trailing slash is allowed and it ends with a slash, try removing the trailing slash and matching.
  3. Unit tests are needed.

@oxsean
Copy link
Collaborator

oxsean commented Jul 22, 2024

Already implemented in PR #14334

@oxsean oxsean closed this Jul 22, 2024
@heliang666s heliang666s deleted the 3.3.7 branch August 16, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants