[Feature][3.3] Triple rest jaxrs ParamConverter support#14148
Merged
AlbumenJ merged 10 commits intoapache:3.3from Jul 22, 2024
Merged
[Feature][3.3] Triple rest jaxrs ParamConverter support#14148AlbumenJ merged 10 commits intoapache:3.3from
AlbumenJ merged 10 commits intoapache:3.3from
Conversation
Member
|
@oxsean PTAL |
Contributor
|
@fanlobu Is it ready for review? |
Contributor
Author
I think it is ok, I did some simple tests in local |
oxsean
reviewed
May 10, 2024
.../src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsParamConverter.java
Outdated
Show resolved
Hide resolved
oxsean
reviewed
May 10, 2024
.../src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsParamConverter.java
Outdated
Show resolved
Hide resolved
oxsean
reviewed
Jun 5, 2024
...rc/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/ParamConverterFactory.java
Outdated
Show resolved
Hide resolved
oxsean
reviewed
Jun 5, 2024
...rc/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/ParamConverterFactory.java
Outdated
Show resolved
Hide resolved
oxsean
reviewed
Jun 5, 2024
...xrs/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/JaxrsRestToolKit.java
Outdated
Show resolved
Hide resolved
oxsean
approved these changes
Jun 9, 2024
Contributor
|
@fanlobu please resolve error-code-inspector error first, You need log with error code |
Contributor
|
LGTM. |
oxsean
approved these changes
Jun 10, 2024
Contributor
Author
Thanks for all the suggestions for my code changes, I've done all the changes, but CICDtest runs failed, I checked the logs but didn't find a solution. Does this test run fail have anything to do with my commit ? |
Contributor
|
Looks like a timeout, you can make a small change, like an empty line or a comment, to trigger the CI again. |
|
AlbumenJ
requested changes
Jun 13, 2024
...rc/main/java/org/apache/dubbo/rpc/protocol/tri/rest/support/jaxrs/ParamConverterFactory.java
Show resolved
Hide resolved
AlbumenJ
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the purpose of the change
Triple rest jaxrs ParamConverter support,related: #14037
Brief changelog
Verifying this change
Checklist