Skip to content

Conversation

@xieshouyu
Copy link
Contributor

What is the purpose of the change

1、fix only consumers unregister serviceInstance

Brief changelog

1、The IP and port of serviceInstance are obtained from the exported metadataService

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@zrlw
Copy link
Contributor

zrlw commented Jun 25, 2025

only consumers unregister serviceInstance

you'd better explain the details of your problem.

@zrlw zrlw added the status/waiting-for-feedback Need reporters to triage label Jun 25, 2025
@xieshouyu
Copy link
Contributor Author

only consumers unregister serviceInstance

you'd better explain the details of your problem.

only consumers unregister serviceInstance

you'd better explain the details of your problem.

When we switch to the service-level shutdown interface, there is no way for our Dubbo console to obtain the subscribers of a specific provider interface. We must obtain metadata from each subscriber through their IP and port to find out. Therefore, even a pure consumer application must have IP and port information.

@zrlw
Copy link
Contributor

zrlw commented Jul 29, 2025

@xieshouyu conflicts should be solved.

@zrlw zrlw requested review from RainYuY and oxsean July 29, 2025 10:34
@xieshouyu
Copy link
Contributor Author

@xieshouyu conflicts should be solved.

@xieshouyu conflicts should be solved.

ok,I recall that this piece of code also resolves the issue where the registration of the consumer configuration does not take effect

@zrlw
Copy link
Contributor

zrlw commented Jul 30, 2025

by the way, your issue might be solved once dubbo-admin is refactored.
see details at apache/dubbo-admin#1300

@zrlw zrlw closed this Aug 1, 2025
@zrlw zrlw reopened this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/waiting-for-feedback Need reporters to triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants