feat: fix #13327 #13334
Closed
feat: fix #13327 #13334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dubbo.jstack-dump.max-line can be used to indicate that all stack trace lines should be printed now - write stack trace info directly into OutputStream instead of building a String
Codecov Report
@@ Coverage Diff @@
## 3.2 #13334 +/- ##
============================================
+ Coverage 65.44% 69.54% +4.10%
Complexity 2 2
============================================
Files 2006 1652 -354
Lines 86319 71608 -14711
Branches 12755 10265 -2490
============================================
- Hits 56494 49802 -6692
+ Misses 24497 17111 -7386
+ Partials 5328 4695 -633 see 512 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
AlbumenJ
requested changes
Nov 8, 2023
dubbo-common/src/main/java/org/apache/dubbo/common/utils/JVMUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
# Conflicts: # dubbo-dependencies-bom/pom.xml # dubbo-dependencies/dubbo-dependencies-zookeeper-curator5/pom.xml # dubbo-dependencies/dubbo-dependencies-zookeeper/pom.xml # pom.xml
Bumps `netty4_version` from 4.1.100.Final to 4.1.101.Final. Updates `io.netty:netty-all` from 4.1.100.Final to 4.1.101.Final - [Commits](netty/netty@netty-4.1.100.Final...netty-4.1.101.Final) Updates `io.netty:netty-bom` from 4.1.100.Final to 4.1.101.Final - [Commits](netty/netty@netty-4.1.100.Final...netty-4.1.101.Final) --- updated-dependencies: - dependency-name: io.netty:netty-all dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: io.netty:netty-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AlbumenJ
requested changes
Nov 14, 2023
| fileOutputStream.set(jStackStream); | ||
| JVMUtil.jstack(jStackStream); |
There was a problem hiding this comment.
Please add some test cases to verify the result
- dubbo.jstack-dump.max-line can be used to indicate that all stack trace lines should be printed now - write stack trace info directly into OutputStream instead of building a String
…into opt-jvm-prt-stk
8 tasks
|
Due to a branch operation error, this PR is reopened in #13358. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #13327
dubbo.jstack-dump.max-linecan be used to indicate that all stack trace lines should be printed now by setting it to a negative number, -1 for example.Brief changelog
update org.apache.dubbo.common.utils.JVMUtil
Verifying this change
Checklist