Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionLoader.getActivateExtension 一个小的优化 #4569

Closed
1 task
sin-ning opened this issue Jul 15, 2019 · 1 comment
Closed
1 task

ExtensionLoader.getActivateExtension 一个小的优化 #4569

sin-ning opened this issue Jul 15, 2019 · 1 comment
Milestone

Comments

@sin-ning
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • [ -] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.3

ExtensionLoader.getActivateExtension

                if (isMatchGroup(group, activateGroup)) {
                    // 这个应该放到 if 里面,会更合适
                    T ext = getExtension(name);
                    if (!names.contains(name)
                            && !names.contains(Constants.REMOVE_VALUE_PREFIX + name)
                            && isActive(activateValue, url)) {
                        exts.add(ext);
                    }
@sin-ning sin-ning changed the title 一个小的优化 ExtensionLoader.getActivateExtension 一个小的优化 Jul 15, 2019
@cvictory
Copy link
Contributor

Can you optimize the code and post pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants