Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource leak in StreamUtils #2413

Closed
biyuhao opened this issue Aug 31, 2018 · 0 comments
Closed

Resource leak in StreamUtils #2413

biyuhao opened this issue Aug 31, 2018 · 0 comments

Comments

@biyuhao
Copy link
Member

biyuhao commented Aug 31, 2018

Environment

  • Dubbo version: master branch latest
  • Operating System version: all
  • Java version: 1.8

Step to reproduce this issue

  1. start StreamUtils UT
  2. using lsof test-class/StreamUtilsTest.txt to check opened file handle

Expected Result

after running all the UT, there shouldn't be any opened handles left

Actual Result

several file handles left

How to fix

  • overwrite the close method of InputStream constructed in limitedInputStream and markSupportedInputStream
  • close the InputStream in corresponding UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@biyuhao