Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-2413] Fix StreamUtils resource leak #2414

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

biyuhao
Copy link
Member

@biyuhao biyuhao commented Aug 31, 2018

What is the purpose of the change

Fix StreamUtils resource leak

Brief changelog

Update StreamUtils.java
Update StreamUtilsTest.java

Verifying this change

UT passed

Fix #2413

@codecov-io
Copy link

Codecov Report

Merging #2414 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2414      +/-   ##
============================================
+ Coverage     54.84%   55.09%   +0.25%     
- Complexity     5238     5284      +46     
============================================
  Files           573      573              
  Lines         25455    25495      +40     
  Branches       4537     4540       +3     
============================================
+ Hits          13960    14046      +86     
+ Misses         9402     9348      -54     
- Partials       2093     2101       +8
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/common/io/StreamUtils.java 84.44% <100%> (+0.53%) 5 <0> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 7% <0%> (-1%)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...ava/org/apache/dubbo/config/ApplicationConfig.java 85.45% <0%> (-2.22%) 57% <0%> (+19%)
...pache/dubbo/registry/support/AbstractRegistry.java 67.41% <0%> (-1.88%) 62% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 44.96% <0%> (+0.67%) 25% <0%> (+1%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.16% <0%> (+0.83%) 31% <0%> (+1%) ⬆️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 78.67% <0%> (+1.47%) 29% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff373a7...266c550. Read the comment docs.

@carryxyh
Copy link
Member

carryxyh commented Sep 3, 2018

Good job.
LGTM.

@diecui1202 diecui1202 merged commit d173e84 into apache:master Sep 6, 2018
@biyuhao biyuhao deleted the pr branch September 6, 2018 15:23
zzzzhougit pushed a commit to zzzzhougit/incubator-dubbo that referenced this pull request Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants